// ... 头部保持不变，建议修改年份 ...
// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.

namespace {

// ... 常量定义增加 ...
constexpr auto kAmService = "org.desktopspec.ApplicationManager1";
constexpr auto kApplicationIface = "org.desktopspec.ApplicationManager1.Application";
constexpr auto kInstanceIface = "org.desktopspec.ApplicationManager1.Instance";
constexpr int kLinglongCacheTTLSeconds = 1800;
constexpr int kDebCacheTTLSeconds = 1800;
constexpr int kDbusTimeoutMs = 1000;
constexpr int kSubprocessTimeoutMs = 3000;

QList<InstanceInfo> queryInstances(const QString &desktopId)
{
    QList<InstanceInfo> result;
    auto appPath = QStringLiteral("/org/desktopspec/ApplicationManager1/%1").arg(escapeToObjectPath(desktopId));

    QDBusInterface appIface(QString::fromUtf8(kAmService),
                            appPath,
                            QStringLiteral("org.freedesktop.DBus.Properties"),
                            QDBusConnection::sessionBus());
    appIface.setTimeout(kDbusTimeoutMs);
    
    QDBusReply<QVariant> reply = appIface.call(QStringLiteral("Get"),
                                                QString::fromUtf8(kApplicationIface),
                                                QStringLiteral("Instances"));
    if (!reply.isValid()) {
        qCDebug(launchDurationReporter) << "[DockIconTiming] queryInstances failed for" << desktopId << ":" << reply.error().message();
        return result;
    }

    const auto paths = qdbus_cast<QList<QDBusObjectPath>>(reply.value());
    for (const auto &path : paths) {
        QDBusInterface instIface(QString::fromUtf8(kAmService),
                                 path.path(),
                                 QStringLiteral("org.freedesktop.DBus.Properties"),
                                 QDBusConnection::sessionBus());
        instIface.setTimeout(kDbusTimeoutMs);

        InstanceInfo info;
        info.instanceId = path.path().section(QLatin1Char('/'), -1);

        // 优化：使用 QDBusReply 简化提取逻辑
        QDBusReply<QVariant> launchTypeReply = instIface.call(QStringLiteral("Get"),
                                               QString::fromUtf8(kInstanceIface),
                                               QStringLiteral("LaunchType"));
        if (launchTypeReply.isValid()) {
            info.launchType = launchTypeReply.value().toString();
        }
        
        if (info.launchType.isEmpty()) {
            info.launchType = QStringLiteral("unknown");
        }

        result.append(info);
    }
    return result;
}

QHash<QString, QString> loadAllLinglongVersions()
{
    QHash<QString, QString> result;

    QProcess proc;
    // 建议：如果 ll-cli 支持 --json，请使用 JSON 解析代替字符串分割
    proc.start(QStringLiteral("ll-cli"), {QStringLiteral("list"), QStringLiteral("--type"), QStringLiteral("app")});
    
    if (!proc.waitForFinished(kSubprocessTimeoutMs)) {
        qCWarning(launchDurationReporter) << "ll-cli list timeout";
        proc.kill();
        proc.waitForFinished();
        return result;
    }

    if (proc.exitCode() != 0) {
        qCWarning(launchDurationReporter) << "ll-cli list failed, exitCode:" << proc.exitCode();
        return result;
    }

    QString output = QString::fromUtf8(proc.readAllStandardOutput());
    QStringList lines = output.split(QLatin1Char('\n'), Qt::SkipEmptyParts);

    // Skip header line
    for (int i = 1; i < lines.size(); ++i) {
        // 优化：使用正则匹配连续空格，防止单元格内包含空格导致错位
        QStringList columns = lines[i].simplified().split(QRegularExpression("\\s+"));
        if (columns.size() >= 3) {
            QString name = columns[1];
            QString version = columns[2];
            if (!name.isEmpty()) {
                result.insert(name, version);
            }
        }
    }

    return result;
}

// 正则表达式验证包名合法性，防止注入或异常字符
static bool isValidDesktopId(const QString &desktopId) {
    static QRegularExpression validNameRegex("^[a-z0-9][a-z0-9+.-]+$");
    return validNameRegex.match(desktopId).hasMatch();
}

} // namespace

namespace dock {

// ... 构造和析构保持不变 ...

void LaunchDurationReporter::reportWindowAppeared(const QString &desktopId)
{
    if (desktopId.isEmpty() || !isValidDesktopId(desktopId)) {
        return;
    }

    // 不需要接收 future 则不接收，避免 Q_UNUSED
    QtConcurrent::run(&m_workerPool, [this, desktopId]() {
        auto instances = queryInstances(desktopId);

        QString uniqueId;
        QString launchType = QStringLiteral("unknown");
        if (!instances.isEmpty()) {
            const auto &latest = instances.constLast();
            uniqueId = latest.instanceId;
            launchType = latest.launchType;
        }

        if (uniqueId.isEmpty()) {
            return;
        }

        QString version;
        QString pakType;

        {
            QMutexLocker locker(&m_cacheMutex);
            qint64 currentTime = QDateTime::currentSecsSinceEpoch();

            if ((currentTime - m_linglongCacheTime) > kLinglongCacheTTLSeconds) {
                m_linglongCache = loadAllLinglongVersions();
                m_linglongCacheTime = currentTime;
            }

            if (m_linglongCache.contains(desktopId)) {
                version = m_linglongCache.value(desktopId);
                pakType = QStringLiteral("linglong");
            } else if (m_debCache.contains(desktopId)) {
                const auto &entry = m_debCache.value(desktopId);
                if ((currentTime - entry.timestamp) <= kDebCacheTTLSeconds) {
                    version = entry.version;
                    pakType = entry.pakType;
                }
            }
        }

        if (pakType.isEmpty()) {
            QProcess proc;
            proc.start(QStringLiteral("dpkg-query"), {QStringLiteral("-W"), QStringLiteral("-f=${Version}"), desktopId});
            proc.waitForFinished(kDbusTimeoutMs); // 复用超时常量
            
            if (proc.exitCode() == 0) {
                version = QString::fromUtf8(proc.readAllStandardOutput()).trimmed();
                pakType = QStringLiteral("deb");
            } else {
                qCDebug(launchDurationReporter) << "dpkg-query failed for" << desktopId << "exitCode:" << proc.exitCode();
                pakType = QStringLiteral("unknown");
            }

            QMutexLocker locker(&m_cacheMutex);
            m_debCache.insert(desktopId, {version, pakType, QDateTime::currentSecsSinceEpoch()});
        }

        QMetaObject::invokeMethod(this, [this, desktopId, uniqueId, launchType, version, pakType]() {
            doReport(desktopId, uniqueId, launchType, version, pakType);
        }, Qt::QueuedConnection);
    });
}

// ... doReport 保持不变 ...

} // namespace dock